Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username can be 16 * 3 bytes #936

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

Outfluencer
Copy link
Contributor

see my pr #843

@Outfluencer
Copy link
Contributor Author

Outfluencer commented Jan 21, 2023

list cases please
and read the conversation of the old pullrequest

@astei astei merged commit 50acf17 into PaperMC:dev/3.0.0 Jan 21, 2023
@xism4
Copy link
Contributor

xism4 commented Jan 23, 2023

list cases please and read the conversation of the old pullrequest

Based on the UTF-8 documentation, encoded strings using Java can reach more than 3*#codepoints.

@hugmanrique
Copy link
Contributor

Java uses a modified UTF-8 encoding, see #843 (comment) for previous discussion.

@xism4
Copy link
Contributor

xism4 commented Jan 23, 2023

Java uses a modified UTF-8 encoding, see #843 (comment) for previous discussion.

I see, so if I didn't see it wrong. Mojang implemented it wrong or just the docs are wrong? What a curiosity

@Outfluencer
Copy link
Contributor Author

Java uses a modified UTF-8 encoding, see #843 (comment) for previous discussion.

I see, so if I didn't see it wrong. Mojang implemented it wrong or just the docs are wrong? What a curiosity

No both are right Java just have a custom impl of utf8 with 3 bytes just read the old conversation…

@xism4
Copy link
Contributor

xism4 commented Jan 23, 2023

Java uses a modified UTF-8 encoding, see #843 (comment) for previous discussion.

I see, so if I didn't see it wrong. Mojang implemented it wrong or just the docs are wrong? What a curiosity

No both are right Java just have a custom impl of utf8 with 3 bytes just read the old conversation…

Thanks for clarifing it, i ported to Waterfall

kashike pushed a commit to PaperMC/Waterfall that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants