Add MergedProperties #226
Draft
Add MergedProperties #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpenilla
added a commit
to PaperMC/Paper
that referenced
this pull request
Nov 29, 2023
This is an alternate way to share dependency versions between api & server to version catalogs (#9974), which have the problem where any catalog change that impacts the generated accessor ABI will cause the entire paperweight pipeline to run again (which makes it impractical for our use case) If we decide to go forward with this, will need to merge PaperMC/paperweight#226 and make a paperweight release first.
|
I wonder if there should be a duplicate check, if a property is defined in multiple property files, that could lead to really meh to find issues and should never be acceptable anyways? |
|
Hm, probably. The more I think about this though the more I start to think we should just pull the versions out of the patches and go with a version catalog in the root project. It should be pretty trivial for forks to pull it in similar to the generated api. (would need to check if this would cause forks to run the pipeline again after applying patches) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.