feat(notebooks): notebook environment variables PS-14130 #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszCki
suggested changes
Jun 19, 2020
|
@BartoszCki tests added |
BartoszCki
previously approved these changes
Jul 2, 2020
|
@BartoszCki I rebased on master, however now the test for loading from yaml is failing. I'm not sure why and if you have any advice I'd appreciate it. Some more detail:
|
BartoszCki
suggested changes
Jul 7, 2020
| "--environment", | ||
| "environment", | ||
| type=json_string, | ||
| help="Environmental variables", |
There was a problem hiding this comment.
The "environment" variable is not loaded from yaml file because you have to use
cls=common.GradientOption,
here. Loading values happens in the GradientOption method.Eevery option has to have the cls set to GradientOption for the yaml loading to work. It's not s perfect solution as one have to remember to put it everywhere but I couldn't find any better at the time I was working on it.
There was a problem hiding this comment.
Ah I must have lost that in the merge. Thanks! I thought I was going nuts.
BartoszCki
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.