fix(workflows): fix workflow logs command not finding logs #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-r-i-k-a
approved these changes
Sep 23, 2021
| default=False, | ||
| cls=common.GradientOption, | ||
| ) | ||
| # TODO (roger): Disabled follow for now since we iterate through multiple workflow job ids |
There was a problem hiding this comment.
do we plan to reenable this? (is there a follow up ticket or project?)
There was a problem hiding this comment.
yep, created a ticket internally
| command.execute(logId, line, limit, follow) | ||
| jobs = workflow_run['status']['jobs'] | ||
| for job in jobs.values(): | ||
| logId = job['logId'] |
There was a problem hiding this comment.
nit to make sure users can differentiate logs by job
lamroger
deleted the
roger/pla-431-bug-gradient-workflows-logs---logid
branch
|
🎉 This PR is included in version 1.8.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
The workflows logs command was looking for logs for the top level run when it should iterate through the jobs for logs.
This also disables the --follow flag for now since we don't support following multiple jobs.