error: this expression creates a reference which is immediately dereferenced by the compiler --> src/api/app/mod.rs:47:51 | 47 | addons.append(&mut source.resolve(&self).await?); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::needless_borrow)]`

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:20:9 | 20 | / match self { 21 | | ServerFlavor::Modded => true, 22 | | _ => false, 23 | | } | |_________^ help: try: `matches!(self, ServerFlavor::Modded)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro --> src/api/models/server/server_flavor.rs:13:9 | 13 | / match self { 14 | | ServerFlavor::Proxy => false, 15 | | _ => true, 16 | | } | |_________^ help: try: `!matches!(self, ServerFlavor::Proxy)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `-D clippy::match-like-matches-macro` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::match_like_matches_macro)]`

error: methods called `into_*` usually take `self` by value --> src/api/models/packwiz/mod.rs:11:29 | 11 | pub async fn into_addon(&self) -> Result<Addon> { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::wrong_self_convention)]`

error: module has the same name as its containing module --> src/api/models/addon/mod.rs:1:1 | 1 | mod addon; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `-D clippy::module-inception` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::module_inception)]`

error: lint group `pedantic` has the same priority (0) as a lint --> Cargo.toml:24:1 | 24 | pedantic = "warn" | ^^^^^^^^ ------ has an implicit priority of 0 25 | missing_docs_in_private_items = "allow" | ----------------------------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority help: to have lints override the group set `pedantic` to a lower priority | 24 | pedantic = { level = "warn", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error: lint group `all` has the same priority (0) as a lint --> Cargo.toml:23:1 | 23 | all = "deny" | ^^^ ------ has an implicit priority of 0 24 | pedantic = "warn" 25 | missing_docs_in_private_items = "allow" | ----------------------------- has the same priority as this lint | = note: the order of the lints in the table is ignored by Cargo = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority = note: `-D clippy::lint-groups-priority` implied by `-D clippy::all` = help: to override `-D clippy::all` add `#[allow(clippy::lint_groups_priority)]` help: to have lints override the group set `all` to a lower priority | 23 | all = { level = "deny", priority = -1 } | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Clippy had exited with the 101 exit code

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

warning: unused `async` for function with no await statements --> src/commands/init.rs:14:1 | 14 | / pub async fn run(mut app: App, args: Args) -> Result<()> { 15 | | 16 | | 17 | | Ok(()) 18 | | } | |_^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/init/mod.rs:27:5 | 27 | / pub async fn init_network(&mut self) -> Result<()> { 28 | | intro("initializing network")?; 29 | | 30 | | let name: String = input("Name of the network?") ... | 39 | | Ok(()) 40 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/app/actions/init/mod.rs:10:5 | 10 | / pub async fn init_server(&mut self) -> Result<()> { 11 | | intro("initializing server")?; 12 | | 13 | | let name: String = input("Name of the server?") ... | 24 | | Ok(()) 25 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/packwiz/mod.rs:11:5 | 11 | / pub async fn into_addon(&self) -> Result<Addon> { 12 | | todo!() 13 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/addon/addon_source.rs:23:5 | 23 | / pub async fn resolve(&self, app: &App) -> Result<Vec<Addon>> { 24 | | match self { 25 | | AddonSource::File { path } => { 26 | | Ok(vec![]) ... | 36 | | } 37 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/addon/addon.rs:23:5 | 23 | / async fn resolve_steps(&self) -> Result<Vec<Step>> { 24 | | Ok(vec![]) 25 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

warning: unused `async` for function with no await statements --> src/api/models/step.rs:46:5 | 46 | / async fn run(&self) -> Result<StepResult> { 47 | | Ok(StepResult::Continue) 48 | | } | |_____^ | = help: consider removing the `async` from this function = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async = note: `-W clippy::unused-async` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`

warning: this match arm has an identical body to another arm --> src/api/models/server/server_flavor.rs:30:13 | 30 | ServerFlavor::Patched => true, | ---------------------^^^^^^^^ | | | help: try merging the arm patterns: `ServerFlavor::Patched | ServerFlavor::Proxy` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_flavor.rs:31:13 | 31 | ServerFlavor::Proxy => true, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this match arm has an identical body to another arm --> src/api/models/server/server_flavor.rs:29:13 | 29 | ServerFlavor::Modded => false, | --------------------^^^^^^^^^ | | | help: try merging the arm patterns: `ServerFlavor::Modded | ServerFlavor::Vanilla` | = help: or try changing either arm body note: other arm here --> src/api/models/server/server_flavor.rs:28:13 | 28 | ServerFlavor::Vanilla => false, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:26:29 | 26 | pub fn supports_plugins(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:19:26 | 19 | pub fn supports_mods(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte) --> src/api/models/server/server_flavor.rs:12:31 | 12 | pub fn supports_datapacks(&self) -> bool { | ^^^^^ help: consider passing by value instead: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref = note: `-W clippy::trivially-copy-pass-by-ref` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::trivially_copy_pass_by_ref)]`

warning: usage of wildcard import --> src/api/models/server/server_type.rs:2:5 | 2 | use crate::api::utils::serde::*; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::api::utils::serde::str_latest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports = note: `-W clippy::wildcard-imports` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::wildcard_imports)]`

warning: field name starts with the struct's name --> src/api/models/addon/addon.rs:18:5 | 18 | pub addon_type: AddonType, | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names = note: `-W clippy::struct-field-names` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::struct_field_names)]`

warning: this match arm has an identical body to another arm --> src/api/models/modpack_source.rs:30:13 | 30 | Self::Remote { modpack_type, .. } => *modpack_type, | ---------------------------------^^^^^^^^^^^^^^^^^ | | | help: try merging the arm patterns: `Self::Remote { modpack_type, .. } | Self::Local { modpack_type, .. }` | = help: or try changing either arm body note: other arm here --> src/api/models/modpack_source.rs:29:13 | 29 | Self::Local { modpack_type, .. } => *modpack_type, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms = note: `-W clippy::match-same-arms` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::match_same_arms)]`

warning: enum `Accessor` is never used --> src/api/utils/accessor.rs:3:10 | 3 | pub enum Accessor { | ^^^^^^^^

warning: methods `init_server` and `init_network` are never used --> src/api/app/actions/init/mod.rs:10:18 | 9 | impl App { | -------- methods in this implementation 10 | pub async fn init_server(&mut self) -> Result<()> { | ^^^^^^^^^^^ ... 27 | pub async fn init_network(&mut self) -> Result<()> { | ^^^^^^^^^^^^

warning: method `collect_addons` is never used --> src/api/app/mod.rs:40:18 | 25 | impl App { | -------- method in this implementation ... 40 | pub async fn collect_addons(&self) -> Result<Vec<Addon>> { | ^^^^^^^^^^^^^^

warning: fields `http_client`, `server`, `network`, and `ci` are never read --> src/api/app/mod.rs:19:5 | 18 | pub struct App { | --- fields in this struct 19 | http_client: reqwest::Client, | ^^^^^^^^^^^ 20 | server: Option<Arc<RwLock<Server>>>, | ^^^^^^ 21 | network: Option<Arc<RwLock<Network>>>, | ^^^^^^^ 22 | ci: bool, | ^^

warning: methods `supports_datapacks`, `supports_mods`, and `supports_plugins` are never used --> src/api/models/server/server_flavor.rs:12:12 | 11 | impl ServerFlavor { | ----------------- methods in this implementation 12 | pub fn supports_datapacks(&self) -> bool { | ^^^^^^^^^^^^^^^^^^ ... 19 | pub fn supports_mods(&self) -> bool { | ^^^^^^^^^^^^^ ... 26 | pub fn supports_plugins(&self) -> bool { | ^^^^^^^^^^^^^^^^

warning: static `PACK_TOML` is never used --> src/api/models/packwiz/packwiz_pack.rs:19:12 | 19 | pub static PACK_TOML: &str = "pack.toml"; | ^^^^^^^^^

warning: method `into_addon` is never used --> src/api/models/packwiz/mod.rs:11:18 | 10 | impl PackwizMod { | --------------- method in this implementation 11 | pub async fn into_addon(&self) -> Result<Addon> { | ^^^^^^^^^^

warning: method `resolve` is never used --> src/api/models/addon/addon_source.rs:23:18 | 22 | impl AddonSource { | ---------------- method in this implementation 23 | pub async fn resolve(&self, app: &App) -> Result<Vec<Addon>> { | ^^^^^^^

warning: method `resolve_steps` is never used --> src/api/models/addon/addon.rs:23:14 | 22 | impl Addon { | ---------- method in this implementation 23 | async fn resolve_steps(&self) -> Result<Vec<Step>> { | ^^^^^^^^^^^^^

warning: method `run` is never used --> src/api/models/step.rs:46:14 | 45 | impl Step { | --------- method in this implementation 46 | async fn run(&self) -> Result<StepResult> { | ^^^

warning: enum `StepResult` is never used --> src/api/models/step.rs:37:10 | 37 | pub enum StepResult { | ^^^^^^^^^^

warning: methods `accessor` and `modpack_type` are never used --> src/api/models/modpack_source.rs:20:12 | 19 | impl ModpackSource { | ------------------ methods in this implementation 20 | pub fn accessor(&self) -> Result<Accessor> { | ^^^^^^^^ ... 27 | pub fn modpack_type(&self) -> ModpackType { | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: variable does not need to be mutable --> src/commands/init.rs:14:18 | 14 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ----^^^ | | | help: remove this `mut`

warning: unused variable: `args` --> src/commands/init.rs:14:32 | 14 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_args`

warning: unused variable: `app` --> src/commands/init.rs:14:22 | 14 | pub async fn run(mut app: App, args: Args) -> Result<()> { | ^^^ help: if this is intentional, prefix it with an underscore: `_app`

warning: variable does not need to be mutable --> src/api/app/actions/init/mod.rs:33:13 | 33 | let mut nw = Network { | ----^^ | | | help: remove this `mut`

warning: variable does not need to be mutable --> src/api/app/actions/init/mod.rs:16:13 | 16 | let mut server = Server { | ----^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused variable: `modpack` --> src/api/models/addon/addon_source.rs:33:36 | 33 | AddonSource::Modpack { modpack } => { | ^^^^^^^ help: try ignoring the field: `modpack: _`

warning: unused variable: `path` --> src/api/models/addon/addon_source.rs:29:35 | 29 | AddonSource::Folder { path } => { | ^^^^ help: try ignoring the field: `path: _`

warning: unused variable: `path` --> src/api/models/addon/addon_source.rs:25:33 | 25 | AddonSource::File { path } => { | ^^^^ help: try ignoring the field: `path: _`

warning: unused variable: `app` --> src/api/models/addon/addon_source.rs:23:33 | 23 | pub async fn resolve(&self, app: &App) -> Result<Vec<Addon>> { | ^^^ help: if this is intentional, prefix it with an underscore: `_app` | = note: `#[warn(unused_variables)]` on by default

warning: unused import: `init::*` --> src/api/app/actions/mod.rs:5:9 | 5 | pub use init::*; | ^^^^^^^

warning: unused import: `build::*` --> src/api/app/actions/mod.rs:4:9 | 4 | pub use build::*; | ^^^^^^^^

warning: unused import: `server_flavor::*` --> src/api/models/server/mod.rs:9:9 | 9 | pub use server_flavor::*; | ^^^^^^^^^^^^^^^^

warning: unused import: `server_type::*` --> src/api/models/server/mod.rs:8:9 | 8 | pub use server_type::*; | ^^^^^^^^^^^^^^

warning: unused import: `packwiz_pack::*` --> src/api/models/packwiz/mod.rs:5:9 | 5 | pub use packwiz_pack::*; | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "mcman-ubuntu-latest", "mcman-windows-latest". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/