Robot Names Can No Longer Be 0 Characters Long #21907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
lewcc
reviewed
Aug 4, 2023
Henri215
reviewed
Aug 5, 2023
ParadiseSS13-Bot
added
-Status: Awaiting review
S34NW
approved these changes
Aug 16, 2023
Furrior
pushed a commit
to Furrior/Paradise-Remake
that referenced
this pull request
Aug 18, 2023
* Add minimum length + warning * Remove nullcheck * The Minimalist Code Initiative
Furrior
pushed a commit
to ss220club/Paradise-SS220
that referenced
this pull request
Aug 18, 2023
* Add minimum length + warning * Remove nullcheck * The Minimalist Code Initiative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #21841 - all robot names must now be at least 1 character long. Also fixed a bug that made the rename dialog pop up twice for floorbots.
Why It's Good For The Game
Things not having names bad.
Testing
Tried giving empty names to the most popular robots, tried giving a normal name to a robot.
Changelog
🆑
fix: Robot names can no longer be 0 characters long
/:cl: