Improved newlines in imports and case statements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdlaar
approved these changes
Jan 11, 2023
pkruithof
commented
Jan 11, 2023
| use PhpCsFixer\RuleSet\Sets\PhpCsFixerSet; | ||
|
|
||
| $csFixerSet = new PhpCsFixerSet(); | ||
|
|
||
| return (new PhpCsFixer\Config('standards')) | ||
| ->setRiskyAllowed(true) | ||
| ->setRules([ | ||
| '@PhpCsFixer' => true, | ||
| '@Symfony:risky' => true, |
There was a problem hiding this comment.
I think at some point we have to drop the @PhpCsFixer ruleset: it has a very large overlap with the @Symfony ruleset, but has some different configuration for some rules. This is kind of confusing, especially when we look up the rules in https://mlocati.github.io/php-cs-fixer-configurator/
pkruithof
commented
Jan 11, 2023
| return (new PhpCsFixer\Config('standards')) | ||
| ->setRiskyAllowed(true) | ||
| ->setRules([ | ||
| '@PhpCsFixer' => true, | ||
| '@Symfony:risky' => true, | ||
| '@PHP80Migration' => true, | ||
| '@PHP80Migration:risky' => true, | ||
| '@PHPUnit84Migration:risky' => true, |
There was a problem hiding this comment.
I believe all projects are php >= 8.1 and phpunit >= 9 at this point.
pkruithof
commented
Jan 11, 2023
| static fn (string $statement): bool => $statement !== 'case', | ||
| ) | ||
| ], | ||
| 'blank_line_between_import_groups' => false, |
There was a problem hiding this comment.
Prevents these messy imports:
class Foo
{
use const AAAA;
use const BBB;
use Acme;
use function DDD;
use AAC;
use function CCC\AA;
use Bar;
}(literally an example of the configurator, I don't understand why they think this is a nice configuration)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated our config to match current settings in
pararius/office, with the exception ofglobal_namespace_import/import_functionssince that would still trigger a very large diff in Casco, I think.