This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
forked from nus-cs2103-AY1920S1/addressbook-level3
-
Notifications
You must be signed in to change notification settings - Fork 4
Branch quiz result #53
Merged
Parcly-Taxel
merged 12 commits into
Parcly-Taxel:master
from
Auxinnn:branch-quiz-result
Oct 17, 2019
Merged
Branch quiz result #53
Parcly-Taxel
merged 12 commits into
Parcly-Taxel:master
from
Auxinnn:branch-quiz-result
Oct 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auxinnn
requested review from
ShirleyWangxt,
shuiyao-sg,
irene-lly and
Parcly-Taxel
October 16, 2019 15:18
# Conflicts: # src/main/java/seedu/address/storage/JsonSerializableAddressBook.java
Parcly-Taxel
suggested changes
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 3 quiz results are stored in the JSON file as of this moment. This arbitrary limit should be removed.
The quiz questions, when they are displayed, are also in the fourth column of the application right now – bring those to the second column!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine in general
@Auxinnn Have you made the changes requested by @Parcly-Taxel? |
@shuiyao-sg Yes I have made the changes. |
irene-lly
reviewed
Oct 17, 2019
Parcly-Taxel
approved these changes
Oct 17, 2019
26 tasks
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update feature of quiz on storage and selection of questions. Can be merged after reviewed.