Add default exception to events #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default exception for handling events such that we can at least display the error message. This is dirty fix for solving this issue, as all exepction are caught like this. We should investigate which exceptions could actually occur, and only use them. Others should be caught by the users themselves.
This commit fixes if a modifier key is pressed without additional key Eg. previous would create control-control combies. Now only control is created Added shift key support Replace format call with f-string QWheelEvent works now with modifier keys
|
OK, that is cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default exception for handling events such that we can at least display the error message.
This is dirty fix for solving this issue, as all exception are caught like this.
We should investigate which exceptions could actually occur, and only use them.
Others should be caught by the users themselves.
This change at least allows users to understand the error which could appear in their own usage of the function.