Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mypy error on missing asttokens.ASTTokens #252

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

mristin
Copy link
Collaborator

@mristin mristin commented Aug 13, 2022

Mypy complained that asttokens.ASTTokens is missing with the newest
asttokens version (2.0.7). Honestly, we are at loss what caused this
error as asttokens/__init__.py did not change. We tried updating
mypy to the latest version (0.971) which did not fix the error either.

We are leaving mypy set to the latest version and fix the mypy error by
explicitly writing asttokens.asttokens.ASTTokens instead of
asttokens.ASTTokens. While it is ugly, it is a quick fix for now.

Mypy complained that ``asttokens.ASTTokens`` is missing with the newest
asttokens version (2.0.7). Honestly, we are at loss what caused this
error as ``asttokens/__init__.py`` did not change. We tried updating
mypy to the latest version (0.971) which did not fix the error either.

We are leaving mypy set to the latest version and fix the mypy error by
explicitly writing ``asttokens.asttokens.ASTTokens`` instead of
``asttokens.ASTTokens``. While it is ugly, it is a quick fix for now.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.972% when pulling 05aefc8 on mristin/Fixed-missing-asttokens.ASTTokens into bb68695 on master.

@mristin mristin merged commit b00c903 into master Aug 13, 2022
@mristin mristin deleted the mristin/Fixed-missing-asttokens.ASTTokens branch August 13, 2022 14:41
mristin added a commit that referenced this pull request Aug 13, 2022
* Added wheels to releases (#251)
* Fixed mypy error on missing ``asttokens.ASTTokens`` (#252)
@mristin mristin mentioned this pull request Aug 13, 2022
mristin added a commit that referenced this pull request Aug 13, 2022
* Added wheels to releases (#251)
* Fixed mypy error on missing ``asttokens.ASTTokens`` (#252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants