Split ParseNetworkInterceptor Module #106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangmengyan95
force-pushed
the
wangmengyan.t8184922_split_Interceptor_module
branch
3 times, most recently
from
3d77a81 to
3f0c67a
Compare
wangmengyan95
force-pushed
the
wangmengyan.t8184922_split_Interceptor_module
branch
from
3f0c67a to
fa3a5fa
Compare
|
It looks like we're missing documentation for various methods in |
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still can not solve the wired robolectric Manifest bug, right now since this test does not heavily rely on the android framework methods, so I manually import json library and remove robolectric dependency. I will try to make a sample project and file the bug to robolectric. Even we can avoid robolectric this time, when we want to modularization in the future, we have to find a solution. @grantland