Clean up third party authentication APIs #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grantland
commented
Sep 11, 2015
grantland
commented
- ParseAuthenticationProvider -> ParseAuthenticationCallbacks
- ParseAuthenticationCallback APIs are synchronous, but executed on bg thread to simplify usage
- ParseAuthenticationCallback APIs are named more callback-y
- ParseUser.registerAuthenticationCallbacks(authType, callback) <- now takes "authType" to match rest of APIs
* ParseAuthenticationProvider -> ParseAuthenticationCallbacks * ParseAuthenticationCallback APIs are synchronous, but executed on bg thread to simplify usage * ParseAuthenticationCallback APIs are named more callback-y * ParseUser.registerAuthenticationCallbacks(authType, callback) <- now takes "authType" to match rest of APIs
grantland
force-pushed
the
grantland.auth_callbacks
branch
from
8bf3e43 to
1f926ad
Compare
There was a problem hiding this comment.
Nit: on a background thread? Don't feel strongly though.
|
LGTM minus documentation. |
grantland
force-pushed
the
grantland.auth_callbacks
branch
from
1f926ad to
51ada3e
Compare
grantland
added a commit
that referenced
this pull request
Sep 14, 2015
Clean up third party authentication APIs
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.