Skip to content

Conversation

YaoPersonal
Copy link

For static OfflineQueryLogic.fetchIncludeAsync, we no longer need to create an instance of OfflineQueryLogic beforehead to do fetchIncludeAsync.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@grantland
Copy link
Contributor

It looks like you missed updating our unit tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

  private Task<Void> fetchIncludeAsync(
      final OfflineStore store
      final Object container,
      final String path,
      final ParseSQLiteDatabase db)

@wangmengyan95
Copy link
Contributor

Several nits from my side, @grantland mind taking a look?

@wangmengyan95
Copy link
Contributor

@YaoPersonal have you signed CLA or linked your Github account to you internal profile?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@grantland
Copy link
Contributor

LGTM! Squash and I'll merge

@YaoPersonal YaoPersonal force-pushed the makestaticfetchinclude branch from 3980ffa to ab9b386 Compare October 5, 2015 20:39
grantland added a commit that referenced this pull request Oct 5, 2015
Make OfflineQueryLogic.fetchIncludeAsync static
@grantland grantland merged commit dbf80ec into parse-community:master Oct 5, 2015
@YaoPersonal YaoPersonal deleted the makestaticfetchinclude branch October 5, 2015 21:31
@facebook-github-bot
Copy link

@YaoPersonal updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants