-
-
Notifications
You must be signed in to change notification settings - Fork 735
Make OfflineQueryLogic.fetchIncludeAsync static #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OfflineQueryLogic.fetchIncludeAsync static #164
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
It looks like you missed updating our unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
private Task<Void> fetchIncludeAsync(
final OfflineStore store
final Object container,
final String path,
final ParseSQLiteDatabase db)
Several nits from my side, @grantland mind taking a look? |
@YaoPersonal have you signed CLA or linked your Github account to you internal profile? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
LGTM! Squash and I'll merge |
cec729c
to
3980ffa
Compare
3980ffa
to
ab9b386
Compare
Make OfflineQueryLogic.fetchIncludeAsync static
@YaoPersonal updated the pull request. |
For static OfflineQueryLogic.fetchIncludeAsync, we no longer need to create an instance of OfflineQueryLogic beforehead to do fetchIncludeAsync.