Decouple object subclassing. #245
Conversation
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
There was a problem hiding this comment.
Similar to the state we have on .NET, we lose this logic during this decouple. Thoughts on a good cross-platform and extensible way to have a hook when a certain class is unregistered?
Also: This becomes irrelevant with automatic subclass registration, which is coming soon™
There was a problem hiding this comment.
Could we keep this for now with a TODO to move to a hook?
The only clean way (in API terms) would be to add listeners/callbacks to ParseObjectSubclassingController for unregister that ParseUser can subscribe to, but that involves a bunch of class allocations...
There was a problem hiding this comment.
Yep, already implemented in fact: https://github.com/ParsePlatform/Parse-SDK-Android/pull/245/files#diff-d1fc53b1cc8d9fefba8e9a00706881e1R104
richardjrossiii
force-pushed
the
richardross.subclassing.decouple
branch
from
057e92f to
90ea274
Compare
|
@richardjrossiii updated the pull request. |
There was a problem hiding this comment.
That specific message? Yes. That error case is still handled by isTypeValid(), however. Without leaking abstraction I'm not sure how we can keep both error messages.
|
Tests should pass again. |
|
@richardjrossiii updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Ignore facebook bot. it's drunk. |
richardjrossiii
added
GH Review: needs-revision
and removed
GH Review: review-needed
labels
This fully decouples object subclassing from the ParseObject class, bringing it up to parity with our other native platforms.
richardjrossiii
force-pushed
the
richardross.subclassing.decouple
branch
from
dfc1ab1 to
d4d9305
Compare
richardjrossiii
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@richardjrossiii updated the pull request. |
|
LGTM! |
…couple Decouple object subclassing.
|
@richardjrossiii updated the pull request. |
This fully decouples object subclassing from the ParseObject class, bringing it up to parity with our other native platforms.