Replace deprecated #310
Replace deprecated #310
Conversation
|
By analyzing the blame information on this pull request, we identified @grantland and @wangmengyan95 to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks good! Would you mind squashing your commits? |
|
No problem. |
|
@daisuke-nomura updated the pull request. |
|
I'm not sure if you attempted this or not, but if you could squash your commits into a single commit we can merge this in. Thanks! |
|
@daisuke-nomura just wondering if you're able to squash these two commits still? |
|
@grantland Sorry for delay. |
|
I'll fix this. |
|
@daisuke-nomura updated the pull request. |
|
Still two commits, mind squashing again? |
|
completed. |
|
thanks! |
|
@daisuke-nomura updated the pull request. |
Use new
bolts.TaskCompletionSource.