-
-
Notifications
You must be signed in to change notification settings - Fork 735
Update ParseLogInterceptor to handle gzip stream #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ParseLogInterceptor to handle gzip stream #33
Conversation
wangmengyan95
commented
Aug 20, 2015
- Update ParseLogInterceptor to handle GZIP response body stream
- Decouple ProxyInputStream (Split the proxy logic and log response logic)
- Clean ParseHttpRequest and ParseHttpResponse
- Add test
4db17a6
to
a421eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to:
public T addHeaders(Map<String, String> headers) {
this.headers.addAll(headers);
return self();
}
Leaving it as setHeaders
where it can clear all old values seem like it could be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get around the problem with final and try/catch by using a local var in the constructor and setting the instance vars after the try/catch.
Last nit, just squash and LGTM |
3b0f8f3
to
0da624a
Compare
…ceptor_to_handle_gzip_android Update ParseLogInterceptor to handle gzip stream
@wangmengyan95 updated the pull request. |