Skip to content

Use OKHttp interceptor list when we use ParseOkHttpClient #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2015
Merged

Use OKHttp interceptor list when we use ParseOkHttpClient #42

merged 1 commit into from
Aug 28, 2015

Conversation

wangmengyan95
Copy link
Contributor

No description provided.

@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.use_OkHttp_interceptor_list_when_we_use_ParseOkHttpClient branch from dd575e4 to 3d3acc8 Compare August 21, 2015 00:40
@wangmengyan95 wangmengyan95 added this to the 1.10.2 milestone Aug 21, 2015
grantland
grantland reviewed Aug 25, 2015
View reviewed changes
Parse/src/main/java/com/parse/ParseOkHttpClient.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have Request getRequest(ParseHttpRequest parseRequest) which is not a static method, to make it consistent I think non-static is better?

@grantland grantland assigned wangmengyan95 and unassigned grantland Aug 25, 2015
@grantland
Copy link
Contributor

Seems like the tests are failing

@grantland grantland assigned wangmengyan95 and unassigned grantland Aug 25, 2015
@grantland
Copy link
Contributor

LGTM

@grantland grantland assigned wangmengyan95 and unassigned grantland Aug 28, 2015
@wangmengyan95 wangmengyan95 force-pushed the wangmengyan.use_OkHttp_interceptor_list_when_we_use_ParseOkHttpClient branch from 3113787 to f46c8bf Compare August 28, 2015 18:35
wangmengyan95 added a commit that referenced this pull request Aug 28, 2015
@wangmengyan95
Merge pull request #42 from ParsePlatform/wangmengyan.use_OkHttp_inte…
300a352 
…rceptor_list_when_we_use_ParseOkHttpClient

Use OKHttp interceptor list when we use ParseOkHttpClient
@wangmengyan95 wangmengyan95 merged commit 300a352 into master Aug 28, 2015
@wangmengyan95 wangmengyan95 deleted the wangmengyan.use_OkHttp_interceptor_list_when_we_use_ParseOkHttpClient branch August 28, 2015 18:40
@facebook-github-bot
Copy link

@wangmengyan95 updated the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wangmengyan95 wangmengyan95

Labels
None yet
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@wangmengyan95 @grantland @facebook-github-bot