Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push adapters are provided by external packages #1195

Merged
merged 2 commits into from
Mar 25, 2016

Conversation

flovilmart
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 93.06%

Merging #1195 into master will increase coverage by +0.45% as of cf968a9

@@            master   #1195   diff @@
======================================
  Files           89      84     -5
  Stmts         5621    5293   -328
  Branches      1014     965    -49
  Methods          0       0       
======================================
- Hit           5206    4926   -280
+ Partial         11      10     -1
+ Missed         404     357    -47

Review entire Coverage Diff as of cf968a9

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart force-pushed the flovilmart.moduleParseServerPush branch from 3ab782c to f2f7c8b Compare March 25, 2016 17:36
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@nlutsenko
Copy link
Contributor

Looks good.
Do you think we should create a common interface for the push adapter? Not sure if we have one already. Also, looking forward to see one signal push adapter decoupled...

@flovilmart
Copy link
Contributor Author

I'm removing OneSignal right now, adding the tests, coverage etc... We have a common interface in PushAdapter.js, but we may wanna move them to https://github.com/parse-server-modules/parse-server-conformance-tests

@flovilmart flovilmart changed the title ParsePushAdapter is a package Push adapters are provided by external packages Mar 25, 2016
@flovilmart flovilmart merged commit d47a756 into master Mar 25, 2016
@flovilmart flovilmart deleted the flovilmart.moduleParseServerPush branch March 25, 2016 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants