Rearrange serializer caching to fix issue #2555 #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
approved these changes
Jul 5, 2023
Prior to this PR: parsl.serialize.facade monkeypatches some serializer objects to create new serializers, but does not generate new identifiers for those new serializers, so two serializers exist in the serializer globals with the same identifier. This patching is done to make some new serializers that have caching behaviour. This leads to issue #2555, where data from one serializer is deserialized using one of the these dynamically defined serializers, incorrectly. This PR removes that monkeypatching and moves caching behaviour into two new serializers explicitly defined for the type of objects that should be cached. This adds two new serializer identifiers, which means there is an incompatible wire protocol change: older versions of parsl will not be able to deserialize callables serialised after this PR. This PR adds a regression test for issue #2555 that fails before this PR. Fixes issue #2555
khk-globus
force-pushed
the
benc-serialization-no-monkeypatch
branch
from
1cc0c5b
to
6c5ade9
Compare
benclifford
removed this pull request from the merge queue due to the queue being cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR:
parsl.serialize.facade monkeypatches some serializer objects to create new serializers, but does not generate new identifiers for those new serializers, so two serializers exist in the serializer globals with the same identifier.
This patching is done to make some new serializers that have caching behaviour.
This leads to issue #2555, where data from one serializer is deserialized using one of the these dynamically defined serializers, incorrectly.
This PR removes that monkeypatching and moves caching behaviour into two new serializers explicitly defined for the type of objects that should be cached.
This adds two new serializer identifiers, which means there is an incompatible wire protocol change: older versions of parsl will not be able to deserialize callables serialised after this PR.
This PR adds a regression test for issue #2555 that fails before this PR.
Fixes issue #2555
Type of change