Make parsl.AUTO_LOGNAME generation pluggable #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A generation function can now be specified at configuration time, with the previous behaviour invoked as default.
benclifford
force-pushed
the
benc-ghent-stdautopath
branch
from
2e0201d
to
c7d6ff8
Compare
khk-globus
reviewed
Apr 25, 2024
Comment on lines
+53
to
+55
| std_autopath : function, optional | ||
| Sets the function used to generate stdout/stderr specifications when parsl.AUTO_LOGPATH is used. If no function | ||
| is specified, generates paths that look like: ``rundir/NNN/task_logs/X/task_{id}_{name}{label}.{out/err}`` |
There was a problem hiding this comment.
NNN is clear to me; what is X in the path name?
There was a problem hiding this comment.
it's str(int(task_id / 10000)).zfill(4) - the 10000s part of the task ID and upwards. I omitted a human description because it's awkwardly verbose for what I intended to be a shortish docstring... I guess something based around "dividing into directories with 10000 tasks each" would work?
There was a problem hiding this comment.
I'm sure this is fine. I imagine most folks won't be looking at this until they have a reason to. Which means they'll be able to see by example what X is.
khk-globus
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A generation function can now be specified at configuration time, with the previous behaviour invoked as default.
Changed Behaviour
None: If this parameter is not specified, parsl.AUTO_LOGNAME should generate the same names as before this PR.
Type of change