Remove unused inputs and outputs fields for AppBase #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
changed the title
benclifford
changed the title
benclifford
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
I also looked through the current code, and also git history, and I think these are two fields that were introduced back at the very start of parsl in 2017 when the task and decorator model was still being unexplored - as far as I can tell, they've been unused for a long time, but not causing anyone problems.
benclifford
pushed a commit
that referenced
this pull request
Jul 2, 2024
…ords, and like bash_app (#3489) In a previous PR (#3485), some fields where the default values of outputs and inputs for AppBase were removed. These fields were not being used in any way. However, like the other parsl reserved parameters, the defaults should have been stored in the AppBase.kwargs dict which is used to ensure that the default values of these special reserved parameters are in invocation_kwargs which is sent to the dataflow kernel and used to resolve the corresponding special behaviors. The correct behavior was only observed in BashApp since it does additional checking to store all default args (even the non-reserved ones) to invocation_kwargs. Now it should be consistent for both types of apps. Changed Behaviour: PythonApp will now correctly resolve default arguments for the inputs and outputs special parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing to see if
AppBaseneedsoutputsandinputsfields or the lines changed are necessary.Changed Behaviour
Removed the last 2 lines of
AppBase.__init__which setAppBase.inputsandAppBase.outputsto default values if they exist.Type of change