Corriger les bugs dans le projet pricer intégration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driox
reviewed
Sep 7, 2022
| @@ -26,6 +26,7 @@ lazy val domain: Project = (project in file("modules/02-domain")) | |||
| .dependsOn(core % "test->test;compile->compile") | |||
|
|
|||
| lazy val new_pricer: Project = (project in file("modules/03-new_pricer")) | |||
| .enablePlugins(PlayScala) | |||
There was a problem hiding this comment.
1 - pour rester iso avec insurance pricer
2 - tu obtiens une erreur lors des tests
Explication :
- tu veux faire un test d'intégration
- tu extends de ta classe de test configuration et Guice
- tu fais ton code test
- tu lances ton code pour tester
- tu obtiens cette erreur : Error injecting constructor, com.typesafe.config.ConfigException$Missing
- ajouter .enablePlugins(PlayScala) résout le problème
Il y a surement une solution qui pourrait laisser le build.sbt de new_pricer + lancer les tests mais quand le presta a eu ce problème je ne voulais pas perdre de temps et j'ai fait la modification dans son code pour qu'il puisse avancer. c'est pour ça que dans sa pr il y a une modification au niveau du build sbt principal.
Mais de manière générale, je veux rester iso avec insurance pricer c'est pourquoi je fais cette pr.
Driox
approved these changes
Sep 7, 2022
Driox
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C'est pour corriger ce bug :
Error injecting constructor, com.typesafe.config.ConfigException$Missing
Quand on tente de faire un test d'intégration pour créer un serveur et utiliser Configuration