Further improve pipeline invocation speed #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…ontext directly instead of the interface and leveraging a bit of unsafe trickery for .NET 6
danielmarbach
force-pushed
the
more-pipeline-optimizations
branch
2 times, most recently
from
4cbc4d8
to
8eb3a30
Compare
danielmarbach
requested review from
bording,
andreasohlund,
lailabougria,
kentdr,
timbussmann,
tmasternak and
DavidBoike
danielmarbach
force-pushed
the
more-pipeline-optimizations
branch
from
8eb3a30
to
b9593af
Compare
bording
approved these changes
May 18, 2022
DavidBoike
approved these changes
May 19, 2022
| var lambdaExpression = Expression.Lambda(body, outerContextParam); | ||
| expressions?.Add(lambdaExpression); | ||
| return lambdaExpression.CompileFast(); | ||
| } | ||
|
|
||
| #if NET | ||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] |
There was a problem hiding this comment.
Does aggressive inlining have any effect since the method is only found via reflection? Or does this affect the compilation of the lambda expression as well?
There was a problem hiding this comment.
I was not able to find any documentation whether expression trees that point to static methods that are aggressively inlined can be properly JITed. I did run tests with and without the inlining hint and I saw 3-5% gains when I added the inlining hint. Unfortunately, I do not have the test results on the laptop I'm currently typing on, but I'm happy to share it later in case you are interested.
timbussmann
reviewed
May 20, 2022
...us.AcceptanceTests/ApprovalFiles/When_pipelines_are_built.Should_preserve_order.approved.txt
Outdated
Show resolved
Hide resolved
tmasternak
approved these changes
May 24, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for .NET 6 as promised in #6237
Further improve pipeline invocation speed by accessing the specific context directly instead of the interface and leveraging a bit of unsafe trickery for .NET 6
This gives us another 11-23% Improvements on top of the latest rounds for the pipeline execution and 3-22% for the exception case. Plus, it simplifies the code because there is less expression tree code available that someone has to process while reading the code.
Additionally we can get rid of the TFM specific approvals because the method call is the same on both TFMs which brings in further cleanup too.
By directly invoking the method on the concrete context instead of
IExtendablea few extra squeezes out of it too that also applies for the .NET Framework version.Pipeline execution
Pipeline exception
Pipeline warmup
Warmup is again slightly slower but that is expected since we are doing slightly more heavy lifting due to creating more generic methods during expression tree baking. It is still though in the
ysarea which is an acceptable price to pay.