Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothing #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Smoothing #18

wants to merge 3 commits into from

Conversation

LiKao
Copy link

@LiKao LiKao commented May 26, 2023

This PR adds a smoothing function (by default gaussian smoothing) as in here.

I am currently in the process of implementing time-continuous multiple-regression (see e.g. here) in R and I am hoping it is possible to integrate this in the mousetrap package, as this seems to be the first go-to location for many researchers. In case this is possible, this would be the first in a series of PRs over the next days.

If this is not possible, I will just try to put this into a separate package depending on mousetrap.

I also added unit testing using the testthat framework for the new functions, as I wanted to ensure the smoothing behaves as expected in all regards. If no unit testing is desired for this project, just let me know and I will create a new PR where I keep this confined to my private repo.

@PascalKieslich
Copy link
Owner

Hi there,
adding TCMR to mousetrap is a great idea. Thanks a lot for your effort! I am happy to take a look at your functions in your pull request and then merge it into mousetrap. However, I may take a few days for this (background: I transitioned into an industry position some time ago - I am still maintaining and developing mousetrap, but have a bit less time for it at the moment).
I also think it is a great idea to add public unit testing to mousetrap. I was planning to do this for some time now, at least for the core functions and would add this after integrating your tests.
So again thanks for contributing this - and I will get back to you in a few days.
Best regards,
Pascal

@LiKao
Copy link
Author

LiKao commented Jun 1, 2023

Ok, good to know. I will then submit some additional PRs to complete the functionality. I will keep the separate parts of TCMR in separate (but possibly dependent) PRs so you can get an overview of the different building blocks and their interactions.

@LiKao
Copy link
Author

LiKao commented Jun 1, 2023

I just found some problems with the smoothing function when the track starts or ends with NA (e.g. angle data). I will add a commit fixing this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants