Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight last comment in the comments tree / Подсветка последнего комментария #630

Closed
kabalin opened this issue Nov 5, 2023 · 3 comments · Fixed by #634
Closed

Highlight last comment in the comments tree / Подсветка последнего комментария #630

kabalin opened this issue Nov 5, 2023 · 3 comments · Fixed by #634
Assignees
@kabalin
Labels
Comments All issues related with a user comments UX/Design Everything related to UX or Design

Comments

@kabalin
Copy link
Member

kabalin commented Nov 5, 2023

Неверно понятая задача #590 привела к решению в котором последний комментарий в дереве комментариев подсвечен. Выношу в отдельный тикет, так как решение готово.

image
@kabalin kabalin added UX/Design Everything related to UX or Design Comments All issues related with a user comments labels Nov 5, 2023
@kabalin
Copy link
Member Author

kabalin commented Nov 5, 2023 •
edited
Loading

Альтернативный вариант подсветки:

image

@kabalin kabalin self-assigned this Nov 5, 2023
@kabalin kabalin mentioned this issue Nov 5, 2023
Open
@paul-k-pastvu
Copy link

У нас уже есть подсветка непрочитанных комментариев. Первый вариант был основан на этом подходе, и это правильно. И он заметнее при скроллинге большого обсуждения.

@paul-k-pastvu
Copy link

Но если в "шапке" обсуждения будет активная ссылка, по которой можно перейти к последнему комментарию, то тогда второй вариант тоже годится.

kabalin added a commit to kabalin/pastvu that referenced this issue Nov 26, 2023
@kabalin
Impelement latest comment in tree link and badge.
31e2f70 
Closes PastVu#630
@kabalin kabalin mentioned this issue Nov 26, 2023
Merged
@kabalin kabalin linked a pull request Nov 26, 2023 that will close this issue
Impelement latest comment in tree link and badge. #634
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kabalin kabalin

Labels
Comments All issues related with a user comments UX/Design Everything related to UX or Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Impelement latest comment in tree link and badge. kabalin/pastvu
2 participants
@kabalin @paul-k-pastvu