Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to src/locales/pull.sh #776

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Conversation

johnschoeman
Copy link
Contributor

Why:
If a user of the i18n:pull script doesn't have lokalise2 available the
script will fail. We would like to include a note to explain this to
readers of the script.

Reference: #711

Why:
If a user of the i18n:pull script doesn't have lokalise2 available the
script will fail. We would like to include a note to explain this to
readers of the script.

Reference: #711
Copy link
Contributor

@mattThousand mattThousand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnschoeman johnschoeman merged commit b6e6d69 into develop Dec 21, 2020
@johnschoeman johnschoeman deleted the jts-update-yarn-pull-script branch December 21, 2020 16:00
tokumori pushed a commit to AlohaSafe/gaen-mobile that referenced this pull request Dec 31, 2020
Why:
If a user of the i18n:pull script doesn't have lokalise2 available the
script will fail. We would like to include a note to explain this to
readers of the script.

Reference: Path-Check#711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants