iOS: Added local notification in terminate function. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat
suggested changes
Apr 15, 2020
|
This happens every time the app is closing. I think it will get annoying if someone is checking each day, or multiple times per day. If you could make it show the warning only the first time they close the app, that would be useful. @kenpugsley @penrods thoughts? |
tstirrat
added
Enhancement
|
I can update show the warning at first time when close the app only. Please confirm? |
|
Yes, I think the first time only warning sounds better. |
tstirrat
reviewed
Apr 20, 2020
…e number 105 to 113] in same function.
thecoder8890
previously approved these changes
Apr 27, 2020
tstirrat
suggested changes
Apr 27, 2020
# Conflicts: # ios/COVIDSafePaths/AppDelegate.m Updated english localize only.
thecoder8890
previously approved these changes
Apr 29, 2020
tstirrat
suggested changes
Apr 29, 2020
tstirrat
previously approved these changes
May 1, 2020
* develop: Update dev README (Path-Check#705) Better error logging in Google import (Path-Check#703) Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724) Translation refresh (Path-Check#708) updated issue template (Path-Check#729)
tstirrat
approved these changes
May 1, 2020
tstirrat
added a commit
that referenced
this pull request
May 2, 2020
* develop: Recommend PR best practices in PR template (#750) Add eslint react-hooks checks (#751) iOS: Added local notification in terminate function. (#521) Update dev README (#705) Better error logging in Google import (#703) Remove rebasing from suggestions in CONTRIBUTING.md (#724) Translation refresh (#708) updated issue template (#729) Set up location after skiping the steps (#721) App shows green icon when tracking is inactive (#722) Fix postinstall script on Windows (#720) Fix isVersionGreater and add tests (#726) update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723) 1.0.1 (#715) Put GPS filter behind dev flag (#714) Fix headline1 text cutoff (#712) Put auto sub behind dev flags (#711) remove default news url from News.js constructor (#704) Fix i18n placeholder for authorities (#709)
tstirrat
added a commit
that referenced
this pull request
May 2, 2020
* develop: (60 commits) Recommend PR best practices in PR template (#750) Add eslint react-hooks checks (#751) iOS: Added local notification in terminate function. (#521) Update dev README (#705) Better error logging in Google import (#703) Remove rebasing from suggestions in CONTRIBUTING.md (#724) Translation refresh (#708) updated issue template (#729) Set up location after skiping the steps (#721) App shows green icon when tracking is inactive (#722) Fix postinstall script on Windows (#720) Fix isVersionGreater and add tests (#726) update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723) 1.0.1 (#715) Put GPS filter behind dev flag (#714) Fix headline1 text cutoff (#712) Put auto sub behind dev flags (#711) remove default news url from News.js constructor (#704) Fix i18n placeholder for authorities (#709) Remove react-native-maps (#695) ...
tstirrat
added a commit
that referenced
this pull request
May 3, 2020
* develop: Add language contribution info to contributing guide (#754) Recommend PR best practices in PR template (#750) Add eslint react-hooks checks (#751) iOS: Added local notification in terminate function. (#521) Update dev README (#705) Better error logging in Google import (#703) Remove rebasing from suggestions in CONTRIBUTING.md (#724)
tstirrat
added a commit
that referenced
this pull request
May 4, 2020
* develop: Build time feature flags (Phase 1) (#694) Extract theme aware <IconButton /> component (#756) Latest i18n pull (#755) Add language contribution info to contributing guide (#754) Recommend PR best practices in PR template (#750) Add eslint react-hooks checks (#751) iOS: Added local notification in terminate function. (#521) Update dev README (#705) Better error logging in Google import (#703) Remove rebasing from suggestions in CONTRIBUTING.md (#724)
aputinski
pushed a commit
to safe-paths-contrib/covid-safe-paths
that referenced
this pull request
May 6, 2020
* official/develop: (110 commits) Consolidate to a single theme aware Button component (Path-Check#767) Fixed incorrect pull command. (Path-Check#769) Update README, etc for tripleblind -> Path-Check (Path-Check#768) HTML EULA translation workflow (Path-Check#710) Allowing setup on macOS/Darwin for Android only. (Path-Check#766) Add Danish to the list of languages. (Path-Check#765) Fixed the aspect ration on the icon and add links (Path-Check#763) Build time feature flags (Phase 1) (Path-Check#694) Extract theme aware <IconButton /> component (Path-Check#756) Latest i18n pull (Path-Check#755) Add language contribution info to contributing guide (Path-Check#754) Recommend PR best practices in PR template (Path-Check#750) Add eslint react-hooks checks (Path-Check#751) iOS: Added local notification in terminate function. (Path-Check#521) Update dev README (Path-Check#705) Better error logging in Google import (Path-Check#703) Remove rebasing from suggestions in CONTRIBUTING.md (Path-Check#724) Translation refresh (Path-Check#708) updated issue template (Path-Check#729) Set up location after skiping the steps (Path-Check#721) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#110
Add Local Push Notification for OnTerminate() - Android #110
Fixed this issue for iOS
How to test
Notification will appear when app killed.