Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some attachments can have a larger radius than others #841

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

NermNermNerm
Copy link

Some tools, particularly watering and scythe, get used a lot in farms that are built around using the tractor. It's really nice to have those tools have a bigger impact area than tools like the hoe, where you'd rather have more precision.

This adds a new setting "ExtendedDistance" to the Scythe, Waterer, Seeder and Fertilizer tools. It's just a boolean setting which allows for one more than the default radius. It's a simple boolean setting to make it simpler for the user. Any area of affect greater than the default 3x3/5x5 throws out all notions of game balance anyway, so the main 'Distance' setting will be good enough for people who want to go bigger.

… a larger area of affect than potentially destructive ones
@@ -7,7 +7,7 @@ internal class StandardAttachmentsConfig
public AxeConfig Axe { get; set; } = new();

/// <summary>Configuration for the fertilizer attachment.</summary>
public GenericAttachmentConfig Fertilizer { get; set; } = new();
public ExtendedDistanceConfig Fertilizer { get; set; } = new() { IncreaseDistance = false };
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fertilizer and seeding, I felt like it fits the "non-destructive" idea, but as for playing this way all the time, I'm not so sure. It's a rarely done activity, so personally, I care more about precision than speed. So I made it something that folks could turn on if they felt differently about it, but left if off by default.

@Pathoschild Pathoschild changed the base branch from alpha to develop February 2, 2024 03:05
@Pathoschild Pathoschild force-pushed the develop branch 2 times, most recently from ed263a9 to 35f23a2 Compare March 9, 2024 04:28
@Pathoschild Pathoschild force-pushed the develop branch 4 times, most recently from 114157c to ac12229 Compare April 4, 2024 03:21
@Pathoschild
Copy link
Owner

We discussed this on Discord, but I'll just summarize here for the record.

I'm planning to change the approach so that, instead of each attachment having an IsDistanceExtended bool option to use a second distance value, players will be able to override the distance per-attachment. In Generic Mod Config Menu, it'd appear as a distance slider where the default value is "use default distance".

I'm mostly working on compatibility updates until the dust settles on the Stardew Valley 1.6 update, so I'll mark this as a draft until we can make those changes.

@Pathoschild Pathoschild marked this pull request as draft April 4, 2024 03:26
@Pathoschild Pathoschild force-pushed the develop branch 3 times, most recently from f491f62 to f664ecc Compare May 25, 2024 03:07
@Pathoschild Pathoschild force-pushed the develop branch 4 times, most recently from febd78c to fb7ce6d Compare June 8, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants