Implement shading without alpha channel #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0916dhkim
commented
Jan 7, 2023
| class DigitalRain { | ||
| constructor(canvasContainer) { | ||
| constructor(canvasContainer, options) { |
There was a problem hiding this comment.
Refactor 1: let the constructor take in an optional parameter options.
Comment on lines
+16
to
+22
| const CHARACTERS = | ||
| "MATRIXMATRIXMATRIXMATRIXMAØ1Ø1Ø1Ø1Ø#$%@&#$%@&ｦｧｨｩｪｫｬｭｮｯｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿﾀﾁﾂﾃﾄﾅﾇﾈﾉﾊﾋﾌﾍﾎﾏﾐﾑﾒﾓﾔﾕﾖﾗﾘﾙﾚﾛﾜﾝｦｧｨｩｪｫｬｭｮｯｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿﾀﾁﾂﾃﾄﾅﾇﾈﾉﾊﾋﾌﾍﾎﾏﾐﾑﾒﾓﾔﾕﾖﾗﾘﾙﾚﾛﾜﾝｦｧｨｩｪｫｬｭｮｯｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿﾀﾁﾂﾃﾄﾅﾇﾈﾉﾊﾋﾌﾍﾎﾏﾐﾑﾒﾓﾔﾕﾖﾗﾘﾙﾚﾛﾜﾝｦｧｨｩｪｫｬｭｮｯｱｲｳｴｵｶｷｸｹｺｻｼｽｾｿﾀﾁﾂﾃﾄﾅﾇﾈﾉﾊﾋﾌﾍﾎﾏﾐﾑﾒﾓﾔﾕﾖﾗﾘﾙﾚﾛﾜﾝ"; | ||
|
|
||
| const getRandomChar = () => { | ||
| const randNum = Math.floor(Math.random() * CHARACTERS.length); | ||
| return CHARACTERS.charAt(randNum); | ||
| }; |
There was a problem hiding this comment.
Refactor 2: Extract characters and getRandomChar outside of the DigitalRain class.
Comment on lines
-569
to
+610
| this.firstChar = null; | ||
| this.secondChar = null; | ||
| this.characters = []; |
There was a problem hiding this comment.
Refactor 3: Replace firstChar & secondChar with characters.
Comment on lines
-341
to
+385
| for (let i = 4; i < stream.streamLength - 3; i++) { | ||
| this.ctx2.fillStyle = "rgba(0, 0, 0, 0.075)"; | ||
| fillRectTweak(this.ctx2, stream.XLOC, stream.YLOC, i); | ||
| for (let i = 4; i < stream.characters.length; i++) { | ||
| const char = stream.characters[i]; | ||
| const settledRgb = parseHex(this.settledColor); | ||
| const multiplier = 1 - (i + 1) / stream.streamLength; | ||
| const shadedRgb = multiplyRgb(settledRgb, multiplier); | ||
| const shadedColor = rgbToHex(shadedRgb); | ||
| clearRectTweak(this.ctx, stream.XLOC, stream.YLOC, i + 1); | ||
| textTweak( | ||
| this.ctx, | ||
| char, | ||
| stream.XLOC, | ||
| stream.YLOC, | ||
| i + 1, | ||
| shadedColor | ||
| ); |
There was a problem hiding this comment.
Alternative way of implementing the gradient shadow effect. This should be more performant because this approach does not use alpha channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.