Implement permissions #59
Conversation
Implement achievement permissions and hook up both achievement and stats permission to the CLI. Need to decide how to hook them up in the GUI.
|
@PaulCombal how do you want to show protected stats/achievements in the GUI? SAM showed them as a red background, but because theming, I'm not so sure if that's what we want to do. If you want to implement it yourself now too, feel free. |
|
How do you feel about an icon with a lock just like the diamond for "rare" or the chart for "next most achived", and disabling the toggle button on the right? Also nice work! I really have to think of a way to make the code cleaner imo asap, since I think there will soon be way enough for a release. |
Make KeyValue::get/get2 always return a node, and check the returned node's validty to check errors instead of NULL check. It is not an error for certain fields to not be present.
Fix 4-space indending. Remove unused functions.
|
Done: I don't really want to restrict the user from trying to change it in case maybe they find out something can be changed! But there's a big warning sign now. |
|
Alright, feel free to merge when you're ready. Did you have time to look for the achievement permission as well (issue #53) ? |
|
Yeah achievement permissions are implemented too. |
Implement the rest of permissions and hook them up to the CLI and eventually GUI.
This brings us to feature parity with the original SAM!