Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy loading dependencies #54

Merged
merged 5 commits into from
Jul 7, 2020
Merged

lazy loading dependencies #54

merged 5 commits into from
Jul 7, 2020

Conversation

kobik
Copy link
Collaborator

@kobik kobik commented Jun 24, 2020

No description provided.

kibertoad
kibertoad reviewed Jun 24, 2020
View reviewed changes
src/utils/fileLoaders.js Outdated Show resolved Hide resolved
kibertoad
kibertoad reviewed Jun 24, 2020
View reviewed changes
src/utils/fileLoaders.js Outdated Show resolved Hide resolved
@kobik kobik changed the title WIP: lazy OAI3 validator initialization WIP: lazy loading dependencies Jun 24, 2020
@kibertoad kibertoad mentioned this pull request Jul 2, 2020
Open
@kibertoad
Copy link
Collaborator

@kobik According to PayU/openapi-validator-middleware#116 (comment), this provides 40% startup time reduction when not using OpenAPI 3.0, so this seems to be clearly helping. Shall we merge it then?

@kobik kobik changed the title WIP: lazy loading dependencies lazy loading dependencies Jul 7, 2020
@kobik kobik merged commit eba9701 into master Jul 7, 2020
@kobik kobik deleted the fix-perf-issues branch July 7, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobik @kibertoad