-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more customisation for Fastify skipList #153
Conversation
@ozonep Could you please add tests for this? |
@kobik Something appears to be wrong, CircleCI is not returning status, wonder if we need to tweak something on CircleCI panel side. Could you please either take a look or give me admin permissions for the repo so that I could take a look? Alternatively I could add GitHub actions CI instead, that one works with zero additional setup, as opposed to Travis and CircleCI. |
Will add tests now. |
will check that |
@ozonep seems to be ok now |
@ozonep Linting is failing, could you please fix the error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme needs to be updated to describe the new structure
Docs updated! |
@kobik This will be a semver major. Are we ready to release that already, or you'd prefer to keep current major going for a while? |
@kibertoad I haven't reviewed the changes, so I can't tell by myself. can't we make it somehow backwards compatible? |
@kobik We could if you strongly prefer keeping it backwards-compatible, but that would add more conditional branching, make code more heavyweight and less performant, and would expose worse API to the end user, so I would vote against it. |
@kibertoad , so a major it is. we need to add the breaking changes note in the changelog file and upgrade procedure from the previous version |
@kibertoad i'd really like to this breaking change to be shipped with other breaking changes such as upgrading to ajv@8 in api-schema-build. |
So we can only skip specific requests (GET/POST/etc.) for specific routes.