Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional unused parameters #966

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Remove additional unused parameters #966

merged 1 commit into from
Nov 7, 2023

Conversation

pierredup
Copy link
Member

No description provided.

@pierredup pierredup added the bug label Nov 7, 2023
@pierredup pierredup added this to the 2.0.0 milestone Nov 7, 2023
@pierredup pierredup self-assigned this Nov 7, 2023
Copy link

what-the-diff bot commented Nov 7, 2023

PR Summary

  • Removal of several classes from rector.php
    Several classes were removed from rector.php. The eliminated classes are: LongArrayToShortArrayRector, StringClassNameToClassConstantRector, RemoveExtraParametersRector, PublicConstantVisibilityRector, AddSeeTestAnnotationRector, and RenameClassRector.

  • Modifications to createMock method
    Numerous modifications were made in different test files to the method createMock. Adjustments made sure that unnecessary arguments and empty string arguments were eliminated. This made the method more efficient as it now exclusively creates a mock object of the 'Api' class or some other specified class.

  • Modifications to specific file methods
    Similar changes were also made to specific methods in multiple test files. For instance, requestClass property in ExecuteSameRequestWithModelDetailsActionTest.php, pathDataProvider method in TokenFactoryTest.php, createFormMock method in ObtainCreditCardActionTest.php, createTwigMock method in RenderTemplateActionTest.php and so on.

  • Changes in toArray method
    The CreateChargeAction.php, CreateCustomerAction.php, CreatePlanAction.php, CreateSubscriptionAction.php, CreateTokenAction.php files have replaced their calls from toArray(true) to toArray(). This modification ensures a more streamlined approach.

@pierredup pierredup merged commit 3f4c919 into master Nov 7, 2023
7 checks passed
@pierredup pierredup deleted the additional-params branch November 7, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant