forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PADV-516 - Allow platform acount association by email. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacatove
suggested changes
Jul 25, 2023
Comment on lines
870
to
886
|
||
# It is not allowed to be associated to a staff or superuser to prevent impersonation. | ||
if users[0].is_staff or users[0].is_superuser: | ||
raise AuthException( | ||
backend, | ||
f'It is not allowed to auto associate staff or superuser users {email}', | ||
) | ||
|
||
# It is not allowed to be associated to an inactive account to prevent impersonation. | ||
if not users[0].is_active: | ||
raise AuthException( | ||
backend, | ||
f'Platform user account is not active: {email} {backend.name}', | ||
) | ||
|
||
return { | ||
'user': users[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# It is not allowed to be associated to a staff or superuser to prevent impersonation. | |
if users[0].is_staff or users[0].is_superuser: | |
raise AuthException( | |
backend, | |
f'It is not allowed to auto associate staff or superuser users {email}', | |
) | |
# It is not allowed to be associated to an inactive account to prevent impersonation. | |
if not users[0].is_active: | |
raise AuthException( | |
backend, | |
f'Platform user account is not active: {email} {backend.name}', | |
) | |
return { | |
'user': users[0], | |
user_account = users[0] | |
# It is not allowed to be associated to a staff or superuser to prevent impersonation. | |
if user_account.is_staff or user_account.is_superuser: | |
raise AuthException( | |
backend, | |
f'It is not allowed to auto associate staff or superuser users {email}', | |
) | |
# It is not allowed to be associated to an inactive account to prevent impersonation. | |
if not user_account.is_active: | |
raise AuthException( | |
backend, | |
f'Platform user account is not active: {email} {backend.name}', | |
) | |
return { | |
'user': user_account, |
Jacatove
approved these changes
Jul 25, 2023
Squirrel18
force-pushed
the
pearson/PADV-516
branch
from
July 25, 2023 21:03
cd0b2a4
to
cd2050d
Compare
Squirrel18
merged commit Jul 25, 2023
c2428f8
into
pearson-release/olive.stage
30 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR allows to associate the edx-platform account with a SAML account under these conditions:
This is necessary to prevent users from logging into their edx-platform account to link the SAML IDP account and the edx-platform account.
How to test:
Notes:
Reviewers: