Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FLTO and Strip #35

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Add FLTO and Strip #35

merged 1 commit into from
Sep 3, 2020

Conversation

juancarlospaco
Copy link
Contributor

  • Add FLTO (Faster Binaries) and Strip (Smaller Binaries) to Nimporter using Nim built-in defines.
  • 2 Lines Diff.

:)

@Pebaz
Copy link
Owner

Pebaz commented Sep 3, 2020

Awesome! Thanks!

@Pebaz Pebaz merged commit f1aadff into Pebaz:master Sep 3, 2020
@Benjamin-Lee
Copy link

Nice work! Are these symbols defined here (nim-lang/Nim#14013)? I've never seen them be passed as -d: options so that's super cool.

@juancarlospaco
Copy link
Contributor Author

Yes they are builtin on Nim itself.

@Benjamin-Lee
Copy link

Sweet. Thanks for the PR! I couldn't find those flags defined anywhere in the docs so I'm impressed.

@juancarlospaco
Copy link
Contributor Author

They live on the CFG of the compiler I think.

@Keithcat1
Copy link

I added those flags recently.
There's a known issue with Mack, but I've submitted a PR and it should get fixed eventually. I didn't think people would start using these flags quite so quickly, but then again, they do make quite a difference sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juancarlospaco @Pebaz @Benjamin-Lee @Keithcat1