Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ensemble/SA filenames #507

Closed
wants to merge 5 commits into from

Conversation

rykelly
Copy link

@rykelly rykelly commented Jun 24, 2015

Both ensemble and sensitivity analysis now save files with ensemble id in the file name. This prevents previous analyses from being automatically overwritten. In particular, when iteratively updating an analysis it is useful to be able to see how model output is changing.

This didn't seem to affect much of the code, but I grepped for and fixed the few places where these files need to be accessed by name.

Currently, the ensemble id needed to name/access files gets passed around in the settings list. This isn't ideal, since it gets overwritten any time a new analysis is performed. Thus PEcAn will always look for the most recent files, which is OK, but better might be if we kept a record of all the ensemble IDs generated within the workflow. I'll work on that in the future, but for now this is a good step.

Also included a separate commit that allows uniform parameter sampling to actually be used when generating the ensemble. The functionality was in there, but with no way to pass an argument to ask for it when using the usual workflow.

Ryan Kelly added 2 commits June 24, 2015 14:00
Both ensemble and sensitivity analysis now save files with
ensemble id in the file name. This prevents previous analyses
from being automatically overwritten. In particular, when
iteratively updating an analysis it is useful to be able to see
how model output is changing.

This didn't seem to affect much of the code, but I grepped for and
fixed the few places where these files need to be accessed by name.

Currently, the ensemble id needed to name/access files gets passed
around in the settings list. This isn't ideal, since it gets overwritten
any time a new analysis is performed. Thus PEcAn will always look
for the most recent files, which is OK, but better might be if we
kept a record of all the ensemble IDs generated within the workflow.
I'll work on that in the future, but for now this is a good step.
Conflicts:
	utils/R/run.write.configs.R
@mdietze
Copy link
Member

mdietze commented Jun 24, 2015

Nice. While this is still fresh in your head, do you think you could update all the variable-specific files to include that variable in the file name. Likewise, all time period specific files should include the time period in the filename as well. If you look at ensemble.analysis.*.pdf you'll see an example of where I included both in the file name. Some files include all variables (e.g. the sensitivity analysis), while others are variable specific (e.g. variance decomposition), but I'm pretty sure all data extractions and figures are the average over a specific time period (which one might want to vary).

@rykelly rykelly closed this Jul 1, 2015
@rykelly rykelly deleted the better_ens+sa_filenames branch July 1, 2015 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants