Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both ensemble and sensitivity analysis now save files with ensemble id in the file name. This prevents previous analyses from being automatically overwritten. In particular, when iteratively updating an analysis it is useful to be able to see how model output is changing.
This didn't seem to affect much of the code, but I grepped for and fixed the few places where these files need to be accessed by name.
Currently, the ensemble id needed to name/access files gets passed around in the settings list. This isn't ideal, since it gets overwritten any time a new analysis is performed. Thus PEcAn will always look for the most recent files, which is OK, but better might be if we kept a record of all the ensemble IDs generated within the workflow. I'll work on that in the future, but for now this is a good step.
Also included a separate commit that allows uniform parameter sampling to actually be used when generating the ensemble. The functionality was in there, but with no way to pass an argument to ask for it when using the usual workflow.