Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

make_raw_transaction (Transaction vs. PeercoinTx) #122

Closed
saeveritt opened this issue Jun 23, 2018 · 4 comments
Closed

make_raw_transaction (Transaction vs. PeercoinTx) #122

saeveritt opened this issue Jun 23, 2018 · 4 comments
Assignees

Comments

@saeveritt
Copy link
Member

We need to pass network parameters to make_raw_transaction in transactions.py or choose between
Transaction and PeercoinTx appropriately.

Inside peerassets-btcpty transaction structs there are two classes, Transaction and PeercoinTx.
https://github.com/PeerAssets/pypeerassets/blob/master/pypeerassets/transactions.py#L66

@peerchemist
Copy link
Member

This is relevant to new, unmerged branch @ belovachap:chapman_check_btcpy_integration

@saeveritt
Copy link
Member Author

I believe it's relevant to both. Right now the master branch uses the Transaction class by default for make_raw_transaction.

@belovachap
Copy link
Contributor

@saeveritt good catch, using the "experimental btcpy" (a.k.a. PeerAssets/btcpy@master) make_raw_transaction is hard coded to just use Bitcoin Transactions at the moment. I'll write a test and make a patch in #121 to either pass network params or otherwise let callers signal the Transaction Class they're working with :)

@peerchemist
Copy link
Member

Network name parameter should be passed indeed.

@belovachap belovachap self-assigned this Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants