Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

WIP - Check integration with new btcpy #121

Merged

Conversation

belovachap
Copy link
Contributor

@peerchemist @saeveritt

We don't have to merge this, just wanted to make sure the newest btcpy changes didn't break anything. All the tests pass and a few more resolved :)

Not sure what other plans you had for testing btcpy, but at least it works for this one case 🎆

@saeveritt
Copy link
Member

Everything looks good. The only thing I see is that the wif property needs to be modified.
to_wif() as per the new btcpy should take the network as an input arg.

    @property
    def wif(self) -> str:
        '''convert raw private key to WIF'''

        btcpy_constants = net_query(self.network).btcpy_constants
        return self._private_key.to_wif(btcpy_constants)

@peerchemist
Copy link
Member

@belovachap can you push the new branch with this code? I'd leave it in testing for a while it's a big change.

@peerchemist peerchemist merged commit 656c939 into PeerAssets:master Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants