Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding DROP MIRROR support for EventHub #402

Merged
merged 3 commits into from
Sep 20, 2023
Merged

adding DROP MIRROR support for EventHub #402

merged 3 commits into from
Sep 20, 2023

Conversation

heavycrystal
Copy link
Contributor

No description provided.

iskakaushik
iskakaushik requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we only drop the slot if we created it, as in replication_slot_name isn't provided for the given mirror?

iskakaushik
iskakaushik reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to land for now and fix it as a follow-up PR

@iskakaushik iskakaushik merged commit e79e11c into main Sep 20, 2023
20 checks passed
@serprex serprex deleted the eventhub-drop-mirror branch July 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik requested changes

@Amogh-Bharadwaj Amogh-Bharadwaj Amogh-Bharadwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heavycrystal @iskakaushik @Amogh-Bharadwaj