This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[MINOR] Idiomatic naming #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Oct 19, 2018
| @@ -90,7 +90,7 @@ public PeerTable(final BytesValue nodeId) { | |||
| } | |||
|
|
|||
| /** | |||
| * Attempts to add the provided peer to the peer table, and returns a struct signalling one of | |||
| * Attempts to add the provided peer to the peer table, and returns an enum signalling one of | |||
There was a problem hiding this comment.
It doesn't return an enum it returns a {@link AddResult} instance.
There was a problem hiding this comment.
but isn't AddResult just a, how to say- wrapper?- around those enums?
There was a problem hiding this comment.
Yes, but it returns an AddResult, not just an enum so we should say that.
smatthewenglish
force-pushed
the
idiomatic-naming
branch
from
01f250a
to
fa253fc
Compare
smatthewenglish
force-pushed
the
idiomatic-naming
branch
from
41067cf
to
bc14576
Compare
smatthewenglish
force-pushed
the
idiomatic-naming
branch
from
ae43784
to
17da507
Compare
ajsutton
approved these changes
Oct 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.