This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1582] Added iBFT 2.0 Hashing functions and header validation rules #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
reviewed
Oct 23, 2018
consensus/common/src/main/java/tech/pegasys/pantheon/consensus/common/VoteType.java
Show resolved
Hide resolved
consensus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashing.java
Outdated
Show resolved
Hide resolved
consensus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashing.java
Show resolved
Hide resolved
consensus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashing.java
Outdated
Show resolved
Hide resolved
consensus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashing.java
Show resolved
Hide resolved
|
|
||
| private static final List<KeyPair> COMMITTERS_KEY_PAIRS = committersKeyPairs(); | ||
| private static final List<Address> VALIDATORS = Arrays.asList(Address.ECREC, Address.SHA256); | ||
| private static final Optional<Vote> VOTE = Optional.of(Vote.authVote(Address.fromHexString("1"))); |
There was a problem hiding this comment.
Is there a reason this needs to be optional?
There was a problem hiding this comment.
Because the IbftExtraData constructor requires an Optional.
consensus/ibft/src/test/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashingTest.java
Outdated
Show resolved
Hide resolved
consensus/ibft/src/test/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashingTest.java
Outdated
Show resolved
Hide resolved
consensus/ibft/src/test/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashingTest.java
Show resolved
Hide resolved
consensus/ibft/src/test/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashingTest.java
Show resolved
Hide resolved
rain-on
reviewed
Oct 24, 2018
|
|
||
| private static BlockHeaderValidator<IbftContext> createValidator( | ||
| final long secondsBetweenBlocks, final boolean validateCommitSeals) { | ||
| return new BlockHeaderValidator.Builder<IbftContext>() |
There was a problem hiding this comment.
do we have a rule to make sure the coinbase is a validator?
There was a problem hiding this comment.
yes. line 80 of IbftExtraDataValidationRule
There was a problem hiding this comment.
needs to be done outside of extra data validation rule ... in my opinion.
consensus/ibft/src/test/java/tech/pegasys/pantheon/consensus/ibft/IbftBlockHashingTest.java
Show resolved
Hide resolved
consensus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/IbftExtraData.java
Outdated
Show resolved
Hide resolved
rain-on
approved these changes
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds the hashing function for iBFT 2.0 and the related header validation rules.
Also, as part of this PR, the interface
ValidatorVoteis introduced so that theVoteTallyclass can be shared between Clique, Ibft Legacy and iBFT 2.0.Types of changes