Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[MINOR] removing symlink file that windows doesn't agree with #146

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

Errorific
Copy link
Contributor

PR description

This is the only symlink file in the repo and it's causing me grief getting the quickstart to run on windows thinking it has no permissions to use the file. While it's nice to remove the duplication, enabling at least the quickstart to run on windows would also be nice. I'm open to other solutions from people more familiar with windows.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Related Issue(s)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Release note


Prerequisites:

  • I have read the CONTRIBUTING.md document and followed the guidelines there.
  • I have commented my code, particularly in hard-to-understand areas
  • I have opened an issue for corresponding changes to documentation (OR no doc changes required)
  • I have added appropriate tests that prove my change is effective

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 definitely no need to symlink this and likely to cause surprises.

@Errorific Errorific merged commit 20cf53b into PegaSysEng:master Oct 25, 2018
@Errorific Errorific deleted the minor/remove_symlink_file branch October 25, 2018 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants