This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Acceptance test - refactor JsonRpc to use conditionals #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
added
acceptance test
work in progress
…ce-test-refactor-jsonrpc
ajsutton
approved these changes
Oct 31, 2018
| } | ||
|
|
||
| @Test | ||
| public void shouldSucceedConnectingToNodeWithWsRpcEnabled() { | ||
| rpcEnabledNode.verifyWsRpcEnabled(); | ||
| rpcEnabledNode.jsonRpcByWebSockets(); |
There was a problem hiding this comment.
Maybe useWebSocketsForJsonRpc?
| public void verify(final Node node) { | ||
| final Throwable thrown = catchThrowable(() -> node.execute(transaction)); | ||
| assertThat(thrown).isInstanceOf(ClientConnectionException.class); | ||
| assertThat(thrown.getMessage()).contains(expectedMessage); |
There was a problem hiding this comment.
Maybe something for the future, but this feels like we could have a ExpectExceptionCondition that delegates to another condition (or maybe just Runnable) and then checks the exception thrown.
| import tech.pegasys.pantheon.tests.acceptance.dsl.node.Node; | ||
| import tech.pegasys.pantheon.tests.acceptance.dsl.transaction.eth.EthGetWorkTransaction; | ||
|
|
||
| public class ExpectEthGetWorkHasThreeNotNullValues implements Condition { |
There was a problem hiding this comment.
nit: Would this be clearer if it were named SanityCheckEthGetWorkValues? Just to be explicit that the requirement isn't really just that there's three arbitrary, non-null values but that's the most we can actually verify about this data.
…ce-test-refactor-jsonrpc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The main goal of this PR was re-writing the JSON-RPC acceptance tests to use the conditionals and through restricting access reduce the opportunity to create non-conditional style AT.
Fixed Issue(s)