This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1402] signers use current signers #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs - use vote tally cache
…rs - missing imports
rain-on
approved these changes
Oct 12, 2018
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Dec 7, 2018
As per AllCoreDevs call PegaSysEng#51 Constantinople fork is 7080000. ethereum/pm#64 https://github.com/ethereum/pm/blob/master/All%20Core%20Devs%20Meetings/Meeting%2051.md
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Dec 7, 2018
As per AllCoreDevs call PegaSysEng#51 Constantinople fork is 7080000. ethereum/pm#64 https://github.com/ethereum/pm/blob/master/All%20Core%20Devs%20Meetings/Meeting%2051.md
shemnon
added a commit
that referenced
this pull request
Dec 7, 2018
As per AllCoreDevs call #51 Constantinople fork is 7080000. ethereum/pm#64 https://github.com/ethereum/pm/blob/master/All%20Core%20Devs%20Meetings/Meeting%2051.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clique signer rpc method were just attempting to return the signers the block header. They must return the current list of validator by apply the votes from last epoch up until the current block.
In addition the Address type that was returned did not serialize to json as expected and so I am converting the address to a string.