Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[NC-862] License headers applied to non-java files #93

Merged
merged 7 commits into from
Oct 18, 2018
Merged

[NC-862] License headers applied to non-java files #93

merged 7 commits into from
Oct 18, 2018

Conversation

mark-terry
Copy link
Contributor

Best viewed by commit. *.gradle files have had headers applied manually, the other filetypes have had rules defined.

macfarla
macfarla reviewed Oct 18, 2018
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the changes to the reference tests

gradle/spotless.bash.license
@@ -0,0 +1,11 @@
# Copyright $YEAR ConsenSys AG.
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$YEAR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substitution variable in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course. sorry!

@CjHare CjHare dismissed a stale review October 18, 2018 07:46

Incorrect assumption

@mark-terry mark-terry merged commit 33cc977 into PegaSysEng:master Oct 18, 2018
@mark-terry mark-terry deleted the NC-862-other=headers branch October 18, 2018 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macfarla macfarla macfarla left review comments

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mark-terry @lucassaldanha @macfarla