Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with Cython3 #21

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix building with Cython3 #21

merged 1 commit into from
Sep 19, 2023

Conversation

arcondello
Copy link
Contributor

Closes #20. Turns out that's not actually an ARM error, but rather a Cython3 one.

I have tested this change with both Cython 0.29.36 and Cython 3.0.0

@JunkyByte
Copy link

Can confirm it builds successfully on Cython 3 and Cython 0.29.36 on a M2 Macbook, thanks!

@arcondello
Copy link
Contributor Author

@Penlect , any chance you could take a look at this one?

@Penlect
Copy link
Owner

Penlect commented Aug 29, 2023

Thanks guys for investigating this. I don't have any Apple hardware myself unfortunately. I need to build new wheels for this, but I noticed that the CI-job fails in its current form. I will try to take a look at this during the weekend.

@arcondello
Copy link
Contributor Author

Thanks!

@arcondello
Copy link
Contributor Author

arcondello commented Sep 19, 2023

Hi @Penlect sorry to ping you again - I am sure you have other stuff on your plate. Any chance for an update? Anything I can help with?

@Penlect Penlect merged commit c46388d into Penlect:master Sep 19, 2023
2 of 5 checks passed
@Penlect
Copy link
Owner

Penlect commented Sep 19, 2023

Hi, sorry, yeah I failed to figure out why the CI-job is failing for macos-11:

    OSError: [Errno 66] Directory not empty: '/Users/runner/work/rectangle-packer/rectangle-packer/.eggs/Cython-3.0.2-py3.9-macosx-10.9-x86_64.egg/Cython-3.0.2.dist-info' -> '/Users/runner/work/rectangle-packer/rectangle-packer/.eggs/Cython-3.0.2-py3.9-macosx-10.9-x86_64.egg/EGG-INFO'
    error: subprocess-exited-with-error

and this is basically blocking me from uploading new wheels.

@arcondello
Copy link
Contributor Author

@Penlect seems to be cython/cython#5568, I could open a PR upper bounding the Cython version or could just wait for that to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build on apple silicon
3 participants