-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Support for transforms #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, very exciting 💯 Some suggestions but nothing blocking. If you pin to the latest PennyLane and the tests pass. I am happy to approve!
@rmoyard since this depends on the main branch of PL and we currently have a undiscovered bug when integrating with the main branch of PL, I'll leave this for now. |
293ed18
to
0e385e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 44 44
Lines 7666 7734 +68
Branches 455 467 +12
=======================================
+ Hits 7638 7706 +68
Misses 14 14
Partials 14 14
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @erick-xanadu great job 💯 It would be nice to gather the possible improvements (relax the return type, support composable transforms) with issues and TODO in the code. Otherwise it looks all good!
Nice work @erick-xanadu! Just a few flyby questions/comments
|
Transforms are restricted to straight-line programs so I don't think autograph would make much sense here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @erick-xanadu!! 💯
50c1bb0
to
597f2a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 💯
Context: Allow PL transforms to be traced in Catalyst
Description of the Change: These changes are implemented on top of the
tape-transform
PR in Catalyst and the development version of PL. These changes apply transforms that are stored on the device into the tape, potentially generating many tapes. Then each tape is traced individually. At last, the classical co-transform is also traced.TODO:
Benefits: Catalyst support for PL transforms.
[sc-41344]