Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix JAX versioning script and compatibility check workflow #311

Merged
merged 20 commits into from
Oct 20, 2023

Conversation

sergei-mironov
Copy link
Contributor

@sergei-mironov sergei-mironov commented Oct 12, 2023

In this PR we do the following:

  • Updates to the JAX versioning script:
    • Supported alternative location of commit constant in the JAX repo
    • Preserve the existing enzyme=<hash> variable while building .dep_versions file
    • Automatically patch JAX version constant found in catalyst.__init__.py
  • Updates to the CI JAX compatibility checker workflow
    • Workflow now checkouts right revisions for LLVM, MHLO and Enzyme
    • Added Python virtual environments to workaround the pip-install problem
    • Re-ordered build steps according to the nstallation guide

The CI workflow that was finished successfully for the current version of JAX is here

[sc-46581]

@sergei-mironov sergei-mironov marked this pull request as ready for review October 13, 2023 05:12
@sergei-mironov
Copy link
Contributor Author

sergei-mironov commented Oct 13, 2023

The workflow should be fixed by now, the interop=false mode has completed successfully. Building everything for jax-0.4.18 has failed because of an LLVM-Enzyme compatibility issue, so no free jax update this time. The frontend also required some minor changes so I created a separate branch for experiments named jax-0.4.18.
image

UPD: The Enzyme version I picked did work with LLVM, but lead to build failure in our dialects. Details here

PS Do we really need a Changelog entry for this PR?

@dime10
Copy link
Contributor

dime10 commented Oct 13, 2023

No changelog required for CI-only changes, unless they affect the package we release.

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks great 👍

.github/workflows/set_dep_versions.py Show resolved Hide resolved
.github/workflows/check-jax-release.yaml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dime10
Copy link
Contributor

dime10 commented Oct 20, 2023

Actually, could you add changelog entry since we updated a requirement?

@sergei-mironov sergei-mironov merged commit 78d6838 into main Oct 20, 2023
19 checks passed
@sergei-mironov sergei-mironov deleted the fix-jax-action branch October 20, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants