-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] PennyLane Measurements PyTrees #315
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 41 41
Lines 7345 7353 +8
Branches 428 430 +2
=======================================
+ Hits 7313 7321 +8
Misses 16 16
Partials 16 16
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @rmoyard!
[sc-46568] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Need to wait for this one amazon-braket/amazon-braket-pennylane-plugin-python#210 and update the braket plugin version. |
@rmoyard looks like it has been merged |
Context:
PennyLane 0.33.0 will introduce measurements as pytrees PennyLaneAI/pennylane#4607
Most measurements have therefore no leaves, this breaks a Catalyst assumptions for capturing the program.
Description of the Change:
is_leaf
true for measurement processes.Benefits:
Catalyst is up to date with PennyLane master
Possible Drawbacks:
Potential slow down
Benchmark:
PL master:
For 100 runs: Version execution time: 6.361672 seconds
PL 0.32.0:
For 100 runs: Version execution time: 6.301733 seconds
Diff: around 0.06s for hundred runs