Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR] Mitigation dialect, ZNE op and lowering(global folding) #324

Merged
merged 46 commits into from
Dec 20, 2023
Merged

[MLIR] Mitigation dialect, ZNE op and lowering(global folding) #324

merged 46 commits into from
Dec 20, 2023

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Oct 19, 2023 •
edited
Loading

Context:

Error mitigation is important for NISQ devices. Zero noise extrapolation is one of the successful mitigation technique.

Description of the Change:

  • Introduce a mitigation dialect that can be used for all the mitigation technique.
  • Introduce a ZNE operation.
  • Introduce a lowering for the ZNE that applies global folding for a integer scalar factors.
    $$U_{folded}=(U*U^{\dagger})^n *U$$

Benefits:

  • Dialect available for mitigation
  • ZNE operation

@rmoyard rmoyard changed the title Draft structure [MLIR] Mitigation dialect and ZNE op Oct 19, 2023
@rmoyard rmoyard changed the title [MLIR] Mitigation dialect and ZNE op [MLIR] Mitigation dialect, ZNE op and lowering(global folding) Nov 9, 2023
@rmoyard
Copy link
Contributor Author

rmoyard commented Nov 9, 2023

[sc-46449]

@rmoyard rmoyard marked this pull request as ready for review November 14, 2023 17:27
@rmoyard rmoyard changed the base branch from main to adjoint_call_op November 14, 2023 17:29
Base automatically changed from adjoint_call_op to main November 20, 2023 18:08
@maliasadi maliasadi added the compiler Pull requests that update the compiler label Dec 6, 2023
@rmoyard rmoyard requested a review from dime10 December 13, 2023 14:35
@rmoyard rmoyard requested review from maliasadi and removed request for dime10 December 18, 2023 15:38
maliasadi
maliasadi reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @rmoyard! 🎉

doc/changelog.md Outdated Show resolved Hide resolved
mlir/include/Mitigation/IR/MitigationDialect.td Show resolved Hide resolved
mlir/include/Mitigation/IR/MitigationDialect.td Show resolved Hide resolved
mlir/include/Mitigation/IR/MitigationOps.h Outdated Show resolved Hide resolved
mlir/include/Mitigation/CMakeLists.txt Outdated Show resolved Hide resolved
mlir/lib/Mitigation/Transforms/MitigationMethods/Zne.cpp Show resolved Hide resolved
mlir/lib/Mitigation/Transforms/MitigationMethods/Zne.cpp Show resolved Hide resolved
mlir/lib/Mitigation/Transforms/MitigationMethods/Zne.cpp Show resolved Hide resolved
mlir/lib/Mitigation/Transforms/MitigationMethods/Zne.cpp Outdated Show resolved Hide resolved
mlir/lib/Mitigation/Transforms/MitigationMethods/Zne.cpp Outdated Show resolved Hide resolved
maliasadi
maliasadi approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯

@rmoyard rmoyard merged commit 7daac77 into main Dec 20, 2023
21 checks passed
@rmoyard rmoyard deleted the mitigation_dialect branch December 20, 2023 15:14
@natestemen natestemen mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliasadi maliasadi maliasadi approved these changes

Assignees
No one assigned
Labels
compiler Pull requests that update the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmoyard @maliasadi